-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "alert on connect", changed design a little #68
Open
fluffyspace
wants to merge
12
commits into
s4ysolutions:master
Choose a base branch
from
fluffyspace:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found new bugs I introduced. I will repair them before opening the pull request again. |
@dsame will you check it out? |
ff5b79f
to
f83aa5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. First of all, thank you for an amazing application and making it free and open source. It's not easy being the only contributor. I love the code you wrote.
I modified the application because I have a cat and I need to get a notification when it comes in range. It would also be amazing to add "passive mode" which wouldn't connect to iTag but rather capture Bluetooth advertisements so that more devices can listen to it. I'm aware that in passive mode the iTag doesn't send advertisements as often as in connected mode but it would be a nice feature.
This is the first time I'm contributing to a project on GitHub, I hope i didn't do bad. I checked for bugs and I couldn't find any, but I'm sure there are some because it's hard to be flawless.
What I did: