Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "alert on connect", changed design a little #68

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

fluffyspace
Copy link

Hi. First of all, thank you for an amazing application and making it free and open source. It's not easy being the only contributor. I love the code you wrote.

I modified the application because I have a cat and I need to get a notification when it comes in range. It would also be amazing to add "passive mode" which wouldn't connect to iTag but rather capture Bluetooth advertisements so that more devices can listen to it. I'm aware that in passive mode the iTag doesn't send advertisements as often as in connected mode but it would be a nice feature.

This is the first time I'm contributing to a project on GitHub, I hope i didn't do bad. I checked for bugs and I couldn't find any, but I'm sure there are some because it's hard to be flawless.

What I did:

  • change color of "forget" button to red
  • change icon of "change color" button to color picker icon so that it's more obvious
  • renamed some methods so it made more sense to me while I developed
  • added alert mode to iTag's settings - no alert, alert on disconnect, alert on connect, alert on both
  • added UUID (or how it's called) below iTag's name on main screen
  • added RSSI text next to RSSI indicator and made RSSI indicator wider
  • added text "Mode: connect/don't connect" to bottom left corner of iTag's display
  • made Bluetooth icon change color based on connection status
  • made iTag's opacity less when it's disconnected
  • cut audios in Audacity to shorter length since it's repeating, to make files smaller
  • added and changed translations

@fluffyspace fluffyspace marked this pull request as draft April 12, 2024 21:16
@fluffyspace
Copy link
Author

I found new bugs I introduced. I will repair them before opening the pull request again.

@fluffyspace fluffyspace marked this pull request as ready for review April 14, 2024 21:29
@fluffyspace
Copy link
Author

@dsame will you check it out?

@dsame dsame force-pushed the master branch 3 times, most recently from ff5b79f to f83aa5d Compare June 13, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant