Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More UMI Stuff (hts_ExtractUMI and hts_SuperDeduper) #264

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bnjenner
Copy link
Collaborator

So this PR has a number of changes.

  1. Additional parameters for EU (specifies separator for PE reads, optionally add UMI as a tag similar to primers) and SD (specifies column for UMI and tag option which looks in the comments of the read.)
  2. SD now correctly handles UMIs from paired end reads (would just double up on the UMI from R1 before).
  3. EU can now add UMIs in 4 ways: To R1, to R2, to both reads individually, or to both reads in tandem (i.e. ACGT+ACGT). I can clarify this a bit more with an example if needed.
  4. Added tests for the new functionality in EU and SD.
  5. Unset UMI delimiter in SD is now a space as to avoid an invalid character in the json files that other programs don't seem to like.

This one is definitely gonna need some review so let me know if any of you would like to schedule a zoom chat to discuss the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant