Added sentry integration. #184
clippy
13 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 13 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.76.0-nightly (06e02d5b2 2023-12-09)
- cargo 1.76.0-nightly (978722961 2023-12-06)
- clippy 0.1.76 (06e02d5 2023-12-09)
Annotations
Check failure on line 69 in src/main.rs
github-actions / clippy
redundant closure
error: redundant closure
--> src/main.rs:69:22
|
69 | .map(|val| Cow::from(val))
| ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Cow::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
Check failure on line 51 in src/main.rs
github-actions / clippy
binding to `_` prefixed variable with no side-effect
error: binding to `_` prefixed variable with no side-effect
--> src/main.rs:51:5
|
51 | let mut _guard = None;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect_underscore_binding
= note: `-D clippy::no-effect-underscore-binding` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::no_effect_underscore_binding)]`
Check failure on line 25 in src/utils/result.rs
github-actions / clippy
consider adding a `;` to the last statement for consistent formatting
error: consider adding a `;` to the last statement for consistent formatting
--> src/utils/result.rs:25:13
|
25 | tracing::debug!(msg)
| ^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `tracing::debug!(msg);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
Check failure on line 28 in src/utils/result.rs
github-actions / clippy
missing `#[must_use]` attribute on a method returning `Self`
error: missing `#[must_use]` attribute on a method returning `Self`
--> src/utils/result.rs:22:5
|
22 | / fn mlog_dbg(self, msg: &str) -> Self {
23 | | #[cfg(debug_assertions)]
24 | | if self._should_log() {
25 | | tracing::debug!(msg)
26 | | }
27 | | self
28 | | }
| |_____^
|
= help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use
Check failure on line 16 in src/utils/result.rs
github-actions / clippy
consider adding a `;` to the last statement for consistent formatting
error: consider adding a `;` to the last statement for consistent formatting
--> src/utils/result.rs:16:13
|
16 | tracing::warn!(msg)
| ^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `tracing::warn!(msg);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
Check failure on line 19 in src/utils/result.rs
github-actions / clippy
missing `#[must_use]` attribute on a method returning `Self`
error: missing `#[must_use]` attribute on a method returning `Self`
--> src/utils/result.rs:14:5
|
14 | / fn mlog_warn(self, msg: &str) -> Self {
15 | | if self._should_log() {
16 | | tracing::warn!(msg)
17 | | }
18 | | self
19 | | }
| |_____^
|
= help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use
Check failure on line 9 in src/utils/result.rs
github-actions / clippy
consider adding a `;` to the last statement for consistent formatting
error: consider adding a `;` to the last statement for consistent formatting
--> src/utils/result.rs:9:13
|
9 | tracing::error!(msg)
| ^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `tracing::error!(msg);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
Check failure on line 12 in src/utils/result.rs
github-actions / clippy
missing `#[must_use]` attribute on a method returning `Self`
error: missing `#[must_use]` attribute on a method returning `Self`
--> src/utils/result.rs:7:5
|
7 | / fn mlog_err(self, msg: &str) -> Self {
8 | | if self._should_log() {
9 | | tracing::error!(msg)
10 | | }
11 | | self
12 | | }
| |_____^
|
= help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use
= note: `-D clippy::return-self-not-must-use` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::return_self_not_must_use)]`
Check failure on line 147 in src/server/mod.rs
github-actions / clippy
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> src/server/mod.rs:147:39
|
147 | span.record("status", &response.status().as_u16());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `response.status().as_u16()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check failure on line 31 in src/server/routes/upload.rs
github-actions / clippy
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> src/server/routes/upload.rs:31:50
|
31 | tracing::Span::current().record("upload_id", &upload_id.as_str());
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `upload_id.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check failure on line 41 in src/notifiers/impls/file_notifier.rs
github-actions / clippy
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> src/notifiers/impls/file_notifier.rs:41:60
|
41 | tracing::Span::current().record("exit_status", &stat.code().unwrap_or(0));
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `stat.code().unwrap_or(0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
Check failure on line 147 in src/data_storage/impls/file_storage.rs
github-actions / clippy
consider adding a `;` to the last statement for consistent formatting
error: consider adding a `;` to the last statement for consistent formatting
--> src/data_storage/impls/file_storage.rs:147:13
|
147 | reader.shutdown().await?
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `reader.shutdown().await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
= note: `-D clippy::semicolon-if-nothing-returned` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::semicolon_if_nothing_returned)]`
Check failure on line 98 in src/data_storage/impls/file_storage.rs
github-actions / clippy
the method `write_all` doesn't need a mutable reference
error: the method `write_all` doesn't need a mutable reference
--> src/data_storage/impls/file_storage.rs:98:26
|
98 | writer.write_all(&mut bytes).await?;
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
= note: `-D clippy::unnecessary-mut-passed` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_mut_passed)]`