Rustus has been rewritten from scratch #180
s3riusAnnotations
67 errors and 15 warnings
|
fmt_check
Process completed with exit code 1.
|
|
unused `async` for function with no await statements:
src/notifiers/impls/amqp_notifier.rs#L44
error: unused `async` for function with no await statements
--> src/notifiers/impls/amqp_notifier.rs:44:5
|
44 | / pub async fn new(options: AMQPHooksOptions) -> RustusResult<Self> {
45 | | let manager = ConnnectionPool::new(
46 | | options.hooks_amqp_url.unwrap().clone(),
47 | | ConnectionProperties::default(),
... |
79 | | })
80 | | }
| |_____^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
= note: `-D clippy::unused-async` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unused_async)]`
|
|
this method could have a `#[must_use]` attribute:
src/utils/lapin_pool.rs#L19
error: this method could have a `#[must_use]` attribute
--> src/utils/lapin_pool.rs:19:5
|
19 | pub fn new(url: String, properties: ConnectionProperties) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(url: String, properties: ConnectionProperties) -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/utils/lapin_pool.rs#L13
error: this method could have a `#[must_use]` attribute
--> src/utils/lapin_pool.rs:13:5
|
13 | pub fn new(pool: mobc::Pool<ConnnectionPool>) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(pool: mobc::Pool<ConnnectionPool>) -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
variables can be used directly in the `format!` string:
src/utils/headers.rs#L88
error: variables can be used directly in the `format!` string
--> src/utils/headers.rs:88:9
|
88 | format!("{}; filename=\"{}\"", disposition, filename)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
88 - format!("{}; filename=\"{}\"", disposition, filename)
88 + format!("{disposition}; filename=\"{filename}\"")
|
|
|
this function could have a `#[must_use]` attribute:
src/utils/dir_struct.rs#L9
error: this function could have a `#[must_use]` attribute
--> src/utils/dir_struct.rs:9:1
|
9 | pub fn substr_time(dir_structure: &str, time: chrono::DateTime<chrono::Utc>) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn substr_time(dir_structure: &str, time: chrono::DateTime<chrono::Utc>) -> String`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this function could have a `#[must_use]` attribute:
src/utils/dir_struct.rs#L4
error: this function could have a `#[must_use]` attribute
--> src/utils/dir_struct.rs:4:1
|
4 | pub fn substr_now(dir_structure: &str) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn substr_now(dir_structure: &str) -> String`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
docs for function returning `Result` missing `# Errors` section:
src/state.rs#L16
error: docs for function returning `Result` missing `# Errors` section
--> src/state.rs:16:5
|
16 | pub async fn from_config(config: &Config) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
item name ends with its containing module's name:
src/state.rs#L9
error: item name ends with its containing module's name
--> src/state.rs:9:12
|
9 | pub struct RustusState {
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
item name ends with its containing module's name:
src/server/mod.rs#L113
error: item name ends with its containing module's name
--> src/server/mod.rs:113:14
|
113 | pub async fn start_server(config: Config) -> RustusResult<()> {
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
docs for function returning `Result` missing `# Errors` section:
src/server/mod.rs#L113
error: docs for function returning `Result` missing `# Errors` section
--> src/server/mod.rs:113:1
|
113 | pub async fn start_server(config: Config) -> RustusResult<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
unneeded `return` statement:
src/server/mod.rs#L73
error: unneeded `return` statement
--> src/server/mod.rs:73:5
|
73 | return resp;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
73 - return resp;
73 + resp
|
|
|
variables can be used directly in the `format!` string:
src/server/routes/upload.rs#L23
error: variables can be used directly in the `format!` string
--> src/server/routes/upload.rs:23:5
|
23 | println!("hehehe {}", upload_id);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
23 - println!("hehehe {}", upload_id);
23 + println!("hehehe {upload_id}");
|
|
|
item name starts with its containing module's name:
src/server/routes/upload.rs#L17
error: item name starts with its containing module's name
--> src/server/routes/upload.rs:17:14
|
17 | pub async fn upload_chunk(
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
redundant closure:
src/server/routes/info.rs#L17
error: redundant closure
--> src/server/routes/info.rs:17:14
|
17 | .map(|ext| ext.to_string())
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::string::ToString::to_string`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
= note: `-D clippy::redundant-closure-for-method-calls` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure_for_method_calls)]`
|
|
item name ends with its containing module's name:
src/server/routes/info.rs#L9
error: item name ends with its containing module's name
--> src/server/routes/info.rs:9:14
|
9 | pub async fn get_server_info(
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
item name ends with its containing module's name:
src/server/routes/file_info.rs#L12
error: item name ends with its containing module's name
--> src/server/routes/file_info.rs:12:14
|
12 | pub async fn get_file_info(
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
item name starts with its containing module's name:
src/server/routes/delete.rs#L15
error: item name starts with its containing module's name
--> src/server/routes/delete.rs:15:14
|
15 | pub async fn delete_upload(
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
this function has too many lines (109/100):
src/server/routes/create.rs#L14
error: this function has too many lines (109/100)
--> src/server/routes/create.rs:14:1
|
14 | / pub async fn create_upload(
15 | | State(ref state): State<RustusState>,
16 | | headers: HeaderMap,
17 | | _body: Bytes,
... |
136 | | .into_response())
137 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
= note: `-D clippy::too-many-lines` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_lines)]`
|
|
item name starts with its containing module's name:
src/server/routes/create.rs#L14
error: item name starts with its containing module's name
--> src/server/routes/create.rs:14:14
|
14 | pub async fn create_upload(
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
this method could have a `#[must_use]` attribute:
src/notifiers/impls/amqp_notifier.rs#L86
error: this method could have a `#[must_use]` attribute
--> src/notifiers/impls/amqp_notifier.rs:86:5
|
86 | pub fn get_queue_name(&self, hook: &Hook) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get_queue_name(&self, hook: &Hook) -> String`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
docs for function returning `Result` missing `# Errors` section:
src/notifiers/impls/amqp_notifier.rs#L44
error: docs for function returning `Result` missing `# Errors` section
--> src/notifiers/impls/amqp_notifier.rs:44:5
|
44 | pub async fn new(options: AMQPHooksOptions) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
src/notifiers/impls/amqp_notifier.rs#L44
error: docs for function which may panic missing `# Panics` section
--> src/notifiers/impls/amqp_notifier.rs:44:5
|
44 | pub async fn new(options: AMQPHooksOptions) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/notifiers/impls/amqp_notifier.rs:46:13
|
46 | options.hooks_amqp_url.unwrap().clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
item in documentation is missing backticks:
src/notifiers/impls/amqp_notifier.rs#L39
error: item in documentation is missing backticks
--> src/notifiers/impls/amqp_notifier.rs:39:27
|
39 | /// ManagerConnection for ChannelPool.
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
39 | /// ManagerConnection for `ChannelPool`.
| ~~~~~~~~~~~~~
|
|
item in documentation is missing backticks:
src/notifiers/impls/amqp_notifier.rs#L39
error: item in documentation is missing backticks
--> src/notifiers/impls/amqp_notifier.rs:39:5
|
39 | /// ManagerConnection for ChannelPool.
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
39 | /// `ManagerConnection` for ChannelPool.
| ~~~~~~~~~~~~~~~~~~~
|
|
this method could have a `#[must_use]` attribute:
src/notifiers/impls/dir_notifier.rs#L17
error: this method could have a `#[must_use]` attribute
--> src/notifiers/impls/dir_notifier.rs:17:5
|
17 | pub fn new(dir: PathBuf) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(dir: PathBuf) -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/notifiers/impls/file_notifier.rs#L16
error: this method could have a `#[must_use]` attribute
--> src/notifiers/impls/file_notifier.rs:16:5
|
16 | pub fn new(command: String) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(command: String) -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/notifiers/impls/http_notifier.rs#L20
error: this method could have a `#[must_use]` attribute
--> src/notifiers/impls/http_notifier.rs:20:5
|
20 | pub fn new(urls: Vec<String>, forward_headers: Vec<String>, timeout_secs: Option<u64>) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(urls: Vec<String>, forward_headers: Vec<String>, timeout_secs: Option<u64>) -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this argument is passed by value, but not consumed in the function body:
src/models/file_info.rs#L101
error: this argument is passed by value, but not consumed in the function body
--> src/models/file_info.rs:101:28
|
101 | pub fn from_json(data: String) -> RustusResult<Self> {
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_pass_by_value)]`
help: consider changing the type to
|
101 | pub fn from_json(data: &str) -> RustusResult<Self> {
| ~~~~
help: change `data.as_str()` to
|
102 | Ok(serde_json::from_str::<Self>(data)?)
| ~~~~
|
|
docs for function returning `Result` missing `# Errors` section:
src/models/file_info.rs#L101
error: docs for function returning `Result` missing `# Errors` section
--> src/models/file_info.rs:101:5
|
101 | pub fn from_json(data: String) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
docs for function returning `Result` missing `# Errors` section:
src/models/file_info.rs#L96
error: docs for function returning `Result` missing `# Errors` section
--> src/models/file_info.rs:96:5
|
96 | pub fn json(&self) -> RustusResult<String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
this method could have a `#[must_use]` attribute:
src/models/file_info.rs#L92
error: this method could have a `#[must_use]` attribute
--> src/models/file_info.rs:92:5
|
92 | pub fn get_filename(&self) -> &str {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get_filename(&self) -> &str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/models/file_info.rs#L74
error: this method could have a `#[must_use]` attribute
--> src/models/file_info.rs:74:5
|
74 | pub fn get_metadata_string(&self) -> Option<String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get_metadata_string(&self) -> Option<String>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/models/file_info.rs#L36
error: this method could have a `#[must_use]` attribute
--> src/models/file_info.rs:36:5
|
36 | / pub fn new(
37 | | file_id: &str,
38 | | length: Option<usize>,
39 | | path: Option<String>,
40 | | storage: String,
41 | | initial_metadata: Option<FxHashMap<String, String>>,
42 | | ) -> FileInfo {
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
help: add the attribute
|
36 ~ #[must_use] pub fn new(
37 + file_id: &str,
38 + length: Option<usize>,
39 + path: Option<String>,
40 + storage: String,
41 + initial_metadata: Option<FxHashMap<String, String>>,
42 ~ ) -> FileInfo {
|
|
|
docs for function returning `Result` missing `# Errors` section:
src/info_storages/mod.rs#L27
error: docs for function returning `Result` missing `# Errors` section
--> src/info_storages/mod.rs:27:5
|
27 | pub async fn new(config: &Config) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
src/info_storages/mod.rs#L27
error: docs for function which may panic missing `# Panics` section
--> src/info_storages/mod.rs:27:5
|
27 | pub async fn new(config: &Config) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/info_storages/mod.rs:32:21
|
32 | info_conf.info_db_dsn.unwrap().as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
item name ends with its containing module's name:
src/info_storages/mod.rs#L11
error: item name ends with its containing module's name
--> src/info_storages/mod.rs:11:10
|
11 | pub enum AvailableInfoStorages {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
useless conversion to the same type: `errors::RustusError`:
src/info_storages/impls/redis_info_storage.rs#L91
error: useless conversion to the same type: `errors::RustusError`
--> src/info_storages/impls/redis_info_storage.rs:91:35
|
91 | None | Some(0) => Err(RustusError::FileNotFound.into()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::FileNotFound`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `errors::RustusError`:
src/info_storages/impls/redis_info_storage.rs#L79
error: useless conversion to the same type: `errors::RustusError`
--> src/info_storages/impls/redis_info_storage.rs:79:24
|
79 | return Err(RustusError::FileNotFound.into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::FileNotFound`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
docs for function returning `Result` missing `# Errors` section:
src/info_storages/impls/redis_info_storage.rs#L46
error: docs for function returning `Result` missing `# Errors` section
--> src/info_storages/impls/redis_info_storage.rs:46:5
|
46 | pub async fn new(db_dsn: &str, expiration: Option<usize>) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
this method could have a `#[must_use]` attribute:
src/info_storages/impls/file_info_storage.rs#L18
error: this method could have a `#[must_use]` attribute
--> src/info_storages/impls/file_info_storage.rs:18:5
|
18 | pub fn info_file_path(&self, file_id: &str) -> PathBuf {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn info_file_path(&self, file_id: &str) -> PathBuf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/info_storages/impls/file_info_storage.rs#L14
error: this method could have a `#[must_use]` attribute
--> src/info_storages/impls/file_info_storage.rs:14:5
|
14 | pub fn new(info_dir: PathBuf) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(info_dir: PathBuf) -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
item in documentation is missing backticks:
src/info_storages/base.rs#L17
error: item in documentation is missing backticks
--> src/info_storages/base.rs:17:59
|
17 | /// about given upload so it can be accessed again by file_id.
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
17 | /// about given upload so it can be accessed again by `file_id`.
| ~~~~~~~~~
|
|
item name ends with its containing module's name:
src/extensions.rs#L2
error: item name ends with its containing module's name
--> src/extensions.rs:2:10
|
2 | pub enum TusExtensions {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
docs for function returning `Result` missing `# Errors` section:
src/data_storage/mod.rs#L31
error: docs for function returning `Result` missing `# Errors` section
--> src/data_storage/mod.rs:31:5
|
31 | pub fn new(config: &Config) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
|
docs for function which may panic missing `# Panics` section:
src/data_storage/mod.rs#L31
error: docs for function which may panic missing `# Panics` section
--> src/data_storage/mod.rs:31:5
|
31 | pub fn new(config: &Config) -> RustusResult<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/data_storage/mod.rs:45:21
|
45 | data_conf.s3_url.clone().unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
item name starts with its containing module's name:
src/data_storage/mod.rs#L25
error: item name starts with its containing module's name
--> src/data_storage/mod.rs:25:10
|
25 | pub enum DataStorageImpl {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
useless conversion to the same type: `errors::RustusError`:
src/data_storage/impls/s3_hybrid.rs#L168
error: useless conversion to the same type: `errors::RustusError`
--> src/data_storage/impls/s3_hybrid.rs:168:13
|
168 | Err(RustusError::Unimplemented("Hybrid s3 cannot concat files.".into()).into())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::Unimplemented("Hybrid s3 cannot concat files.".into())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `errors::RustusError`:
src/data_storage/impls/s3_hybrid.rs#L102
error: useless conversion to the same type: `errors::RustusError`
--> src/data_storage/impls/s3_hybrid.rs:102:24
|
102 | return Err(RustusError::UnableToWrite("Cannot get upload path.".into()).into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::UnableToWrite("Cannot get upload path.".into())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
docs for function which may panic missing `# Panics` section:
src/data_storage/impls/s3_hybrid.rs#L38
error: docs for function which may panic missing `# Panics` section
--> src/data_storage/impls/s3_hybrid.rs:38:5
|
38 | / pub fn new(
39 | | endpoint: String,
40 | | region: String,
41 | | access_key: &Option<String>,
... |
51 | | force_fsync: bool,
52 | | ) -> Self {
| |_____________^
|
note: first possible panic found here
--> src/data_storage/impls/s3_hybrid.rs:62:13
|
62 | panic!("Cannot build credentials: {err}")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `-D clippy::missing-panics-doc` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::missing_panics_doc)]`
|
|
this method could have a `#[must_use]` attribute:
src/data_storage/impls/s3_hybrid.rs#L38
error: this method could have a `#[must_use]` attribute
--> src/data_storage/impls/s3_hybrid.rs:38:5
|
38 | / pub fn new(
39 | | endpoint: String,
40 | | region: String,
41 | | access_key: &Option<String>,
... |
51 | | force_fsync: bool,
52 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
help: add the attribute
|
38 ~ #[must_use] pub fn new(
39 + endpoint: String,
40 + region: String,
41 + access_key: &Option<String>,
42 + secret_key: &Option<String>,
43 + security_token: &Option<String>,
44 + session_token: &Option<String>,
45 + profile: &Option<String>,
46 + custom_headers: &Option<String>,
47 + bucket_name: &str,
48 + force_path_style: bool,
49 + data_dir: PathBuf,
50 + dir_struct: String,
51 + force_fsync: bool,
52 ~ ) -> Self {
|
|
|
item name starts with its containing module's name:
src/data_storage/impls/s3_hybrid.rs#L30
error: item name starts with its containing module's name
--> src/data_storage/impls/s3_hybrid.rs:30:12
|
30 | pub struct S3HybridStorage {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
useless conversion to the same type: `errors::RustusError`:
src/data_storage/impls/file_storage.rs#L157
error: useless conversion to the same type: `errors::RustusError`
--> src/data_storage/impls/file_storage.rs:157:28
|
157 | return Err(RustusError::FileNotFound.into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::FileNotFound`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `errors::RustusError`:
src/data_storage/impls/file_storage.rs#L134
error: useless conversion to the same type: `errors::RustusError`
--> src/data_storage/impls/file_storage.rs:134:32
|
134 | return Err(RustusError::FileNotFound.into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::FileNotFound`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `errors::RustusError`:
src/data_storage/impls/file_storage.rs#L80
error: useless conversion to the same type: `errors::RustusError`
--> src/data_storage/impls/file_storage.rs:80:24
|
80 | return Err(RustusError::FileNotFound.into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::FileNotFound`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `errors::RustusError`:
src/data_storage/impls/file_storage.rs#L63
error: useless conversion to the same type: `errors::RustusError`
--> src/data_storage/impls/file_storage.rs:63:24
|
63 | return Err(RustusError::FileNotFound.into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RustusError::FileNotFound`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
|
|
docs for function returning `Result` missing `# Errors` section:
src/data_storage/impls/file_storage.rs#L34
error: docs for function returning `Result` missing `# Errors` section
--> src/data_storage/impls/file_storage.rs:34:5
|
34 | pub fn data_file_path(&self, file_id: &str) -> RustusResult<PathBuf> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `-D clippy::missing-errors-doc` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::missing_errors_doc)]`
|
|
this method could have a `#[must_use]` attribute:
src/data_storage/impls/file_storage.rs#L26
error: this method could have a `#[must_use]` attribute
--> src/data_storage/impls/file_storage.rs:26:5
|
26 | pub fn new(data_dir: PathBuf, dir_struct: String, force_fsync: bool) -> FileStorage {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn new(data_dir: PathBuf, dir_struct: String, force_fsync: bool) -> FileStorage`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
item in documentation is missing backticks:
src/data_storage/base.rs#L25
error: item in documentation is missing backticks
--> src/data_storage/base.rs:25:33
|
25 | /// This method must return HttpResponse.
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `-D clippy::doc-markdown` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
|
25 | /// This method must return `HttpResponse`.
| ~~~~~~~~~~~~~~
|
|
this method could have a `#[must_use]` attribute:
src/config.rs#L323
error: this method could have a `#[must_use]` attribute
--> src/config.rs:323:5
|
323 | pub fn get_url(&self, url: &str) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get_url(&self, url: &str) -> String`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/config.rs#L300
error: this method could have a `#[must_use]` attribute
--> src/config.rs:300:5
|
300 | pub fn parse() -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn parse() -> Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: `-D clippy::must-use-candidate` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::must_use_candidate)]`
|
|
more than 3 bools in a struct:
src/config.rs#L164
error: more than 3 bools in a struct
--> src/config.rs:164:1
|
164 | / pub struct AMQPHooksOptions {
165 | | /// Url for AMQP server.
166 | | #[arg(long, env = "RUSTUS_HOOKS_AMQP_URL")]
167 | | pub hooks_amqp_url: Option<String>,
... |
232 | | pub hooks_amqp_idle_channels_timeout: Option<u64>,
233 | | }
| |_^
|
= help: consider using a state machine or refactoring bools into two-variant enums
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_excessive_bools
= note: `-D clippy::struct-excessive-bools` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::struct_excessive_bools)]`
|
|
item name ends with its containing module's name:
src/config.rs#L41
error: item name ends with its containing module's name
--> src/config.rs:41:12
|
41 | pub struct DataStorageConfig {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
|
|
item name ends with its containing module's name:
src/config.rs#L11
error: item name ends with its containing module's name
--> src/config.rs:11:12
|
11 | pub struct InfoStorageConfig {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions
= note: `-D clippy::module-name-repetitions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::module_name_repetitions)]`
|
|
binding's name is too similar to existing binding:
src/utils/headers.rs#L41
error: binding's name is too similar to existing binding
--> src/utils/headers.rs:41:17
|
41 | let val = kval.next();
| ^^^
|
note: existing binding defined here
--> src/utils/headers.rs:39:21
|
39 | let mut kval = meta_entry.trim().split(' ');
| ^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names
|
|
binding's name is too similar to existing binding:
src/server/mod.rs#L25
error: binding's name is too similar to existing binding
--> src/server/mod.rs:25:9
|
25 | let res = next.run(req).await;
| ^^^
|
note: existing binding defined here
--> src/server/mod.rs:14:5
|
14 | req: axum::extract::Request,
| ^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names
= note: `-D clippy::similar-names` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::similar_names)]`
|
|
code_check
Clippy had exited with the 101 exit code
|
|
fmt_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
code_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|