[ci-suggested-fix] Using docker hub build hook #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 13, 2019 17:22
Signed-off-by: ed kim <[email protected]>
Signed-off-by: ed kim <[email protected]>
Signed-off-by: ed kim <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 64.96% 64.96%
=======================================
Files 4 4
Lines 137 137
=======================================
Hits 89 89
Misses 42 42
Partials 6 6Continue to review full report at Codecov.
|
|
Wow! I've never realized that Docker Hub had the build env support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Be able to inject
--build-argvariables from the environment.WHY
A colleague and myself noticed how the docker images were being pushed on docker hub for this repo from the README.md link. We wanted newer images that could be built directly from the master branch here.
Instead I'd like to propose a number of buildable docker images repositories (e.g. /metricbeat and /filebeat) each pointing to the master branch of this repo.
Within the Docker hub build configuration section, you can declare the environment variables like so:
Variables such as
BEAT_DOCKER_IMAGEandBEAT_NAMEwould be defined on the environment. TheIMAGE_TAGwould need ideally be semver'd in some way...Relates to the builds of images from this issue