Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python3.8 support #1979

Merged
merged 3 commits into from
Oct 26, 2024

py39 for pypy, too

37779e8
Select commit
Loading
Failed to load commit list.
Merged

Drop python3.8 support #1979

py39 for pypy, too
37779e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 26, 2024 in 0s

82.23% (+0.59%) compared to e88159f

View this Pull Request on Codecov

82.23% (+0.59%) compared to e88159f

Details

Codecov Report

Attention: Patch coverage is 92.80303% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (e88159f) to head (37779e8).

Files with missing lines Patch % Lines
miio/devtools/simulators/miiosimulator.py 0.00% 7 Missing ⚠️
miio/devtools/simulators/miotsimulator.py 0.00% 3 Missing ⚠️
miio/devtools/pcapparser.py 0.00% 2 Missing ⚠️
...iio/integrations/lumi/gateway/devices/subdevice.py 33.33% 2 Missing ⚠️
miio/integrations/roborock/vacuum/vacuum.py 77.77% 2 Missing ⚠️
miio/discovery.py 66.66% 1 Missing ⚠️
...io/integrations/chuangmi/camera/chuangmi_camera.py 66.66% 1 Missing ⚠️
miio/miioprotocol.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
+ Coverage   81.63%   82.23%   +0.59%     
==========================================
  Files         197      197              
  Lines       19134    19127       -7     
  Branches     4209     1050    -3159     
==========================================
+ Hits        15620    15729     +109     
- Misses       3216     3220       +4     
+ Partials      298      178     -120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov