-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roborock: various improvements to exposed sensors #1914
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1914 +/- ##
==========================================
- Coverage 81.42% 81.41% -0.01%
==========================================
Files 193 193
Lines 18628 18636 +8
Branches 4041 4045 +4
==========================================
+ Hits 15167 15173 +6
- Misses 3179 3180 +1
- Partials 282 283 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR, @SLaks! Did you mark this as a draft on purpose, or should this be merged right away?
I marked this as draft because I couldn't test it due to rytilahti/homeassistant-xiaomi-ng#1. Feel free to merge it; I may send followup PRs after #1916 merges to fix other issues or add other features (eg, I plan to add a sensor for WiFi signal strength). |
And make this declarative.
This avoids showing `%20` in UI. Warning: I didn't verify that changing the map works, because it stopped showing me other choices after this. Not sure why.
Update: I verified that the map dropdown works correctly. However, it resets to the first map in the list (which, incidentally, is the map the robot is physically in) after 10 seconds or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested on gen1 vac. We can either merge this and continue on subsequent PRs, or leave this open for the time being, your call.
Based on the icons used by the HA native Roborock integration
Using enum with options shows a dropdown of available values when building conditions or triggers in HA.
Note: Only newer models have this (Q Revo is the only one I know of). HA shows the sensor as `unknown` for other models; I don't know how to exclude it.
I pushed a WiFi strength sensor. This is everything I wanted to add at the moment; I may send followups if I discover more issues |
Thanks! I updated the title & description to be a bit more descriptive for the git logs, I hope that's fine with you. |
Of course
Thanks!
…On Tue, Mar 19, 2024, 9:16 PM Teemu R. ***@***.***> wrote:
Merged #1914 <#1914> into
master.
—
Reply to this email directly, view it on GitHub
<#1914 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMUJSOKJF3H5P6G6ILQH3YZDPOPAVCNFSM6AAAAABE2QB65OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGE3TQMRYGMZTSMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
clean_percent
options
,device_class
,suggested_display_precision
on specific sensors for better homeassistant integration