Make Device.sensors() only return read-only descriptors #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1871 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 193 193
Lines 18563 18563
Branches 4025 4025
=======================================
Hits 15111 15111
Misses 3171 3171
Partials 281 281 ☔ View full report in Codecov by Sentry. |
rytilahti
added a commit
that referenced
this pull request
Feb 16, 2024
Also, optimize future status queries a bit by constructing the status query already during the initialization phase. Fixes a regression caused by #1871, the genericmiot requires deliberately some tests to avoid such, but it's better to have basic functionalities working on master so I'll merge this asap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was incorrectly returning also readable settings, this changes the behavior to conform with the docstring.