Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support dreame.vacuum.ma1808 and dreame.vacuum.mb1808 #1774

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR, @st7105! I'll see to get the CI fixed so we can get this merged soon.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1774 (2ba0b51) into master (76808d8) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

❗ Current head 2ba0b51 differs from pull request most recent head 05bbb6f. Consider uploading reports for the commit 05bbb6f to get more accurate results

@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
- Coverage   80.88%   80.86%   -0.02%     
==========================================
  Files         193      193              
  Lines       18594    18604      +10     
  Branches     4019     4021       +2     
==========================================
+ Hits        15039    15045       +6     
- Misses       3277     3281       +4     
  Partials      278      278              
Files Coverage Δ
...io/integrations/dreame/vacuum/dreamevacuum_miot.py 74.05% <63.63%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase on top of the current master branch and remove the changes irrelevant to dreame.vacuum*?

@@ -58,6 +58,25 @@
# Indicator light (siid=7)
"led_brightness": {"siid": 7, "piid": 1},
},
"leshow.heater.nfj3lx": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are irrelevant changes, right?

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants