-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support dreame.vacuum.ma1808 and dreame.vacuum.mb1808 #1774
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR, @st7105! I'll see to get the CI fixed so we can get this merged soon.
This reverts commit 2546b04.
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
==========================================
- Coverage 80.88% 80.86% -0.02%
==========================================
Files 193 193
Lines 18594 18604 +10
Branches 4019 4021 +2
==========================================
+ Hits 15039 15045 +6
- Misses 3277 3281 +4
Partials 278 278
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rebase on top of the current master branch and remove the changes irrelevant to dreame.vacuum*?
@@ -58,6 +58,25 @@ | |||
# Indicator light (siid=7) | |||
"led_brightness": {"siid": 7, "piid": 1}, | |||
}, | |||
"leshow.heater.nfj3lx": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are irrelevant changes, right?
Quality Gate passedIssues Measures |
https://home.miot-spec.com/spec/dreame.vacuum.ma1808
https://home.miot-spec.com/spec/dreame.vacuum.mb1808