Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword string in metainfo #221

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

daPhipz
Copy link
Contributor

@daPhipz daPhipz commented Dec 4, 2023

This sounds a bit nicer IMO - but I am not a native speaker, so I might be totally wrong xD

@ryonakano
Copy link
Owner

@daPhipz Thank you for your contribution! Changes look good to me.
Just one thing, would you also update the following sentence in the README.md to the same sentence?

https://github.com/ryonakano/reco/blob/main/README.md?plain=1#L13

@daPhipz
Copy link
Contributor Author

daPhipz commented Dec 4, 2023

Of course! Like this?

Copy link
Owner

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right! Thank you for the fix.

@ryonakano ryonakano merged commit 767cee2 into ryonakano:main Dec 4, 2023
3 checks passed
@ryonakano ryonakano added this to the 5.0.1 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants