Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace # with _ for lua #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace # with _ for lua #7

wants to merge 1 commit into from

Conversation

minamorl
Copy link

Hi, I'm using neovim with lua and since there' s no way to represent # in lua I just replaced it with underscore.

@ryicoh
Copy link
Owner

ryicoh commented Apr 28, 2024

@minamorl Thank you for posting the PR.

In lua, you can use '#' in a variable name, such as vim.g['deepl#endpoint’].

@ryicoh ryicoh closed this Apr 28, 2024
@minamorl
Copy link
Author

Hi. First I like this plugin really!
IMHO it'd be better to have documented or replace it with underscore since it's de facto way to represent variable in recent nvim plugins.

@ryicoh ryicoh reopened this May 1, 2024
@ryicoh
Copy link
Owner

ryicoh commented May 1, 2024

@minamorl

I agree with you.
But I'm concerned that the change will become a breaking change.
It means that it will affect users who are already configured in deepl#....

Do you have any ideas to avoid this?

@minamorl
Copy link
Author

minamorl commented May 6, 2024

@ryicoh Ah OK I got the point. So it would be better to check both old deepl#endpoint and new deepl_endpoint if you wanna leave them for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants