Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

update lodash for security issue #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update lodash for security issue #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This package provides easy IP based access control. This can be achieved either
[![Circle CI](https://circleci.com/gh/baminteractive/express-ipfilter/tree/master.svg?style=svg)](https://circleci.com/gh/baminteractive/express-ipfilter/tree/master)

## Version
0.3.1
0.3.2

## Installation

Expand Down Expand Up @@ -156,6 +156,10 @@ This will run `eslint`,`babel`, and `mocha` and output coverage data into `cover

## Changelog

0.3.2
* Bump the lodash version due to security concerns
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to https://nodesecurity.io/advisories/577

* Update lodash usage in `src/ipfulter.js` for tests to pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in filename: src/ipfilter.js


0.3.1
* Fixes critical bug that allowed access when ips is empty and mode == 'allow'.
* Adds minor speed improvements for middleware.
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "express-ipfilter",
"description": "A light-weight IP address based filtering system",
"version": "0.3.1",
"version": "0.3.2",
"author": "BaM Interactive",
"dependencies": {
"ip": "~1.1.0",
"lodash": "~3.10.1",
"lodash": "^4.17.10",
"range_check": "^1.2.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/ipfilter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ module.exports = function ipfilter(ips, opts) {
var matchClientIp = function(ip){
var mode = settings.mode.toLowerCase();

var result = _.invoke(getIps(),testIp,ip,mode);
var result = _.invokeMap(getIps(),testIp,ip,mode);

if(mode === 'allow'){
return _.some(result);
Expand Down