Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

Disable VIDEO_ROCKCHIP_HDMIRX in config #66

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnull
Copy link
Contributor

@gnull gnull commented Dec 6, 2024

This disables the hdmirx kernel module and prevents the dmesg spam of #37. This disables hdmirx for all devices, not only those that are affected by dmesg spam.

It would be much cleaner to simply disable the hdmirx in device tree, but I can't fathom where does it get enabled. As explained in #37 (comment), the upstream source code seems to have hdmirx node disabled, but for some reason it has status "okay" on my device and the driver gets loaded, producing the spam.

I don't know of a way to cleanly disable hdmirx in DT, so will keep the PR here in case someone finds it.

Ivan

@gnull
Copy link
Contributor Author

gnull commented Dec 6, 2024

The PR is currently rebased on top of #64 (which is about to get merged to master).

@gnull gnull force-pushed the hdmirx-config-fix branch from 6ef36e6 to d4c4c8e Compare December 7, 2024 14:08
@gnull
Copy link
Contributor Author

gnull commented Dec 7, 2024

I tried a few cleaner ways to disable the faulty device in Device Tree, but all seem to fail:

  1. Kernel patch modifying the arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts to set &hdmirx_ctrler { status = "disabled; };.

  2. Removing arch/arm64/boot/dts/rockchip/overlay/rk3588-hdmirx.dts with a patch from kernel source (in case this overlay was getting applied automatically).

  3. Adding an overlay with roughly &hdmirx_ctrler { status = "disabled; }; here.

None of the steps help modify the device tree value. After I reboot, I still get

$ cat /sys/firmware/devicetree/base/hdmirx-controller@fdee0000/status
okay

@ryan4yin is there something I misunderstand about how we build the kernel and DT? Does bootloader to anything special with it? Right now, it seems that there's no way to modify DT, even though NixOS normally allows it via overlays.

@ryan4yin
Copy link
Owner

Hello Ivan.
It has become challenging for me to maintain this project due to my limited expertise in the Linux kernel.
After careful consideration, I've decided to archive it. You can find more information in #71.

Thanks for this PR & your past contributions! ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants