Support deterministic findTag #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrowlingson
commented
Dec 13, 2016
|
|
||
| var tags = fs.readdirSync(tagsPath); | ||
| var tags = findPackedTags(gitPath, sha) | ||
| .concat(findUnpackedTags(gitPath, sha)); |
There was a problem hiding this comment.
The sort order of readdir and the packed-ref file is not guaranteed. Granted, it is unlikely that either will change but this gives some extra confidence that findTag() will remain deterministic.
|
I think this needs a rebase? |
jrowlingson
force-pushed
the
deterministic-tag
branch
from
8ab6321
to
eb72263
Compare
jrowlingson
force-pushed
the
deterministic-tag
branch
from
eb72263
to
7a64a06
Compare
|
@rwjblue Ah, yep - rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Depends on #31This change set includes some ground-work for #33