Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, except for a few select mouse buttons, keyd does not support remapping keys with an event code higher than 256. This is reasonable and I don't propose changing it. However, right now it discards all keys that it doesn't know how to remap. That's not ideal and it prevents using keyd with arbitrary USB devices.
This does two things:
uint8_t
touint16_t
. Otherwise, we simply can't store the keycodes, they wrap around.I tested this with a Forty4 GC201 game controller and Celeste through Steam; before this change it did not register any inputs, and afterwards it works fine.
cc #842 (comment), hopefully this addresses some of your concerns there.