Use autotools (autoconf, automake) to build keyd #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more likely to match user systems.
This makes it easier to build inside a chroot jail, for example.
The `-f` option causes `rm` to silently ignore files that don't exist, so `rm -rf` will only fail if `rm` has trouble deleting a file that exists. We want `make` to fail in that situation.
We want `make` to fail if the directory doesn't exist and can't be made for some reason.
rhansen
added a commit
to keyd-project/keyd-fork
that referenced
this pull request
Dec 6, 2024
|
FYI, this was merged into https://github.com/keyd-project/keyd-fork as keyd-project/keyd-fork@8afb7c0 |
rhansen
force-pushed
the
autotools
branch
2 times, most recently
from
343efe2 to
ce7734e
Compare
Only some Debian flavors are tested for now; other distros can be easily added later.
rhansen
added a commit
to keyd-project/keyd-fork
that referenced
this pull request
Dec 18, 2024
This syncs the latest changes made to rvaiya/keyd#831
rhansen
added a commit
to keyd-project/keyd-fork
that referenced
this pull request
Dec 18, 2024
|
I am not interested adding a bunch of dependencies to the build system. The project has almost no dependencies and does not require anything other than a simple make file. Autotools adds no value and was avoided by design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for downstream distributions to package keyd.
Also add a GitHub workflow to run the tests, check the distribution tarball, and upload the distribution tarball as an artifact whenever a PR is opened or a new revision is pushed to the repository.
This PR is marked as a draft because it depends on #642, #674, and #675 which have not yet been merged. Once those are merged I will rebase this and mark it as ready for review.