Playwright testing #478
Merged
Playwright testing #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the default GITHUB_TOKEN
|
You are using the production url to test the branch. You should use |
|
@sergiobeltranguerrero @marcgc21 requested that the production is tested. I can look into testing development as well sometime later. |
added 5 commits
June 4, 2024 18:21
# Conflicts: # .github/workflows/ishikawa-tools.yml # ishikawa_tools/ishikawa_tools_script.py # package.json
|
|
|
jvJUCA
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds adds playwright UI tests, as well as a github action that runs them. This is part of the quality controll subject of which Marc is the professor. Attention should be payed to the change in the Jest configuration. As it stands right now any test contained in a folder called e2e (at any depth) will be ignored by Jest. This change was required because the last configuration was matching any files ending in .spec.js and tried to run playwright tests as unit test and therefore the test GH action would always fail.