use js_sys::Uint8Array::view instead #223
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of direct access to wasm-memory for the regular tutorial and Uint32Array for the bits
exercise.
Summary
I learned that directly accessing webassembly shared memory is not needed anymore, easier to write and equally efficient are
js_sys
typed Array views. This change of the tutorial in the book goes together with my PR for the code rustwasm/wasm_game_of_life#53I hope my explanations of what is going on are sufficient, but please let me know if wording should change, english is not my primary language.
Note: I decided to change the algorithm for
bitIsSet
and use of aUint32Array
for the cells in the bits exercise because staying withUint8Array
would have meant this ugly rust code: