fixes a few problems with flakebox shell tooling #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`echo **.nix` only lists files ending in `.nix` in the current dir and ignores subdirectories
… output The output that the `pre-commmit` hook, and in extension `just lint` produces when this command is run cannot be attributed to cargo for first time users. This commit adds marker at the end of the line indicating the command output stems from (cargo)
As per cargo test man page (`cargo help test`) a simple `cargo test` already tests the doc tests of the lib target (which is what --doc also does) Additionally `cargo test --doc` throws an error if there are no doc tests available
dpc
reviewed
Aug 9, 2024
| @@ -38,7 +38,6 @@ final-check: lint clippy | |||
| if [ ! -f Cargo.toml ]; then | |||
| cd {{invocation_directory()}} | |||
| fi | |||
| cargo test --doc | |||
There was a problem hiding this comment.
Hmmm...
As per cargo test man page (`cargo help test`) a simple `cargo test`
already tests the doc tests of the lib target
(which is what --doc also does)
Additionally `cargo test --doc` throws an error if there are no doc
tests available
dpc
approved these changes
Aug 9, 2024
|
Let's give it a go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packagesargument is no longer ignored)just lintgives more descriptive output for out of date cargo dependenciesjust formatcatches all.nixfiles and no longer ignores subdirectoriescommit-msghook no longer suggests non existing git option (typo?)