Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisory for unsound problems in kvm-ioctls #2174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Manciukic
Copy link

@Manciukic Manciukic commented Dec 20, 2024

Undefined behaviour in kvm_ioctls::ioctls::vm::VmFd::create_device

An issue was identified in the VmFd::create_device function, leading to undefined behavior and miscompilations on rustc 1.82.0 and newer due to the function's violation of Rust's pointer safety rules.

The function downcasted a mutable reference to its struct kvm_create_device argument to an immutable pointer, and then proceeded to pass this pointer to a mutating system call. Rustc 1.82.0 and newer elides subsequent reads of this structure's fields, meaning code will not see the value written by the kernel into the fd member. Instead, the code will observe the value that this field was initialized to prior to calling VmFd::create_device (usually, 0).

The issue started in kvm-ioctls 0.1.0 and was fixed in 0.19.1 by correctly using
a mutable pointer.

Co-authored-by: Patrick Roy <[email protected]>
Signed-off-by: Riccardo Mancini <[email protected]>
@Manciukic Manciukic force-pushed the kvm-ioctls/create-device-undefined-behaviour branch from 9158225 to 9928017 Compare December 20, 2024 11:41
@Manciukic Manciukic marked this pull request as ready for review December 20, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants