subject_name: more specific errs for invalid names. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 93.78% 93.74% -0.04%
==========================================
Files 14 13 -1
Lines 2573 2574 +1
==========================================
Hits 2413 2413
- Misses 160 161 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Previously the `presented_id_matches_constraint` and `presented_id_matches_reference_id` functions used by `verify_cert_dns_name` would return an `Option<bool>`, with the `None` case translated into `Error::BadDer`. This makes it difficult for downstream users to know that the encoding error was specific to an invalid presented DNS ID, or a name constraint. This commit introduces two new error variants: `MalformedDnsIdentifier` and `MalformedNameConstraint`. The `presented_id_matches_constraint` and `presented_id_matches_reference_id` functions are changed to return `Result<bool, Error>` using the new error types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
presented_id_matches_constraintandpresented_id_matches_reference_idfunctions used byverify_cert_dns_namewould return anOption<bool>, with theNonecase translated intoError::BadDer. This makes it difficult for downstream users to know that the encoding error was specific to an invalid presented DNS ID, or a DNS name constraint.This commit introduces two new error variants:
MalformedDnsIdentifierandMalformedNameConstraint. Thepresented_id_matches_constraintandpresented_id_matches_reference_idfunctions are changed to returnResult<bool, Error>using the new error types. This better matches thepresented_id_matches_reference_idandpresented_id_matches_constraintimpls. used forIpAddresssubjects that already returnResult<bool, Error>, allowing yielding aInvalidNetworkMaskConstrainterror.Resolves #59