Skip to content

Add context to signature-related errors #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

Add context to signature-related errors #357

merged 3 commits into from
Jun 20, 2025

Conversation

djc
Copy link
Member

@djc djc commented Jun 16, 2025

Fixes #356.

This could use some feedback. In particular, the macro encoding of alg_tests is fairly painful to update for this. Any suggestions how best to do that? I started on unwrapping some the macro test wrappers in another branch but that would a decent amount of boilerplate (though it does make things a bit more obvious).

@djc djc requested review from cpu and ctz June 16, 2025 11:42
@djc djc marked this pull request as draft June 16, 2025 11:43
@djc djc force-pushed the sig-alg-context branch from e43df29 to 804817b Compare June 18, 2025 10:40
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 97.65258% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (8081620) to head (085ee9b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/crl/mod.rs 0.00% 4 Missing ⚠️
src/error.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.02%     
==========================================
  Files          20       20              
  Lines        4729     4901     +172     
==========================================
+ Hits         4634     4802     +168     
- Misses         95       99       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc force-pushed the sig-alg-context branch from 804817b to f9d0968 Compare June 18, 2025 10:42
@djc djc marked this pull request as ready for review June 18, 2025 10:42
@djc djc force-pushed the sig-alg-context branch 3 times, most recently from 83b6643 to f836776 Compare June 18, 2025 16:23
@djc djc force-pushed the sig-alg-context branch from f836776 to 136e242 Compare June 20, 2025 12:04
@djc djc force-pushed the sig-alg-context branch from 136e242 to 085ee9b Compare June 20, 2025 12:20
@djc djc requested a review from ctz June 20, 2025 12:22
@djc
Copy link
Member Author

djc commented Jun 20, 2025

Moved the algorithm encodings from src/data/test to tests/signatures/alg-* -- because this is test-only, seems better to keep them outside src.

@djc djc added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit cbd72bc Jun 20, 2025
38 of 40 checks passed
@djc djc deleted the sig-alg-context branch June 20, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add context to signature-related errors
2 participants