-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DER parsing #142
Refactor DER parsing #142
Conversation
This is `pub(crate)` and doesn't seem to provide any extra abstraction.
Use the equivalent expect_tag() instead.
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 96.01% 96.24% +0.22%
==========================================
Files 15 15
Lines 4065 4259 +194
==========================================
+ Hits 3903 4099 +196
+ Misses 162 160 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me. I have some suggestions for the error variant names but I don't feel strongly if you disagree with the suggestions I've made.
838cf36
to
d30aa65
Compare
Okay, |
Now that we no longer depend on generic ring things, there is a bunch of stuff we can do to simplify DER handling.