Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error for malformed DNS IDs #59

Closed
cpu opened this issue May 2, 2023 · 0 comments · Fixed by #60
Closed

Better error for malformed DNS IDs #59

cpu opened this issue May 2, 2023 · 0 comments · Fixed by #60
Assignees
@cpu

Comments

@cpu
Copy link
Member

cpu commented May 2, 2023

Presently when webpki encounters an invalidly encoded DNS identifier (for e.g. a subject alternate name dNSName) the verify_is_valid_for_subject_name fn of an end entity cert returns a generic BadDer error. It would be more helpful if we could indicate that it's an encoding error with a subject name in particular.

Related to #38, rustls/rustls#1292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

subject_name: more specific errs for invalid names.
1 participant
@cpu