Add Kotlin Gradle script example to Android README section #167
Conversation
|
I don't think I have the experience to be able to review this change. |
|
That's perfectly ok, thanks for the heads up. I just wanted to at least give the other maintainers a chance to look it over. Does it sound fine to wait another week or so for Daniel (as the other person who's worked on Android stuff) and after that just proceed with merging this? These are just documentation changes and I'm entirely confident in the Kotlin script itself being correct. |
There was a problem hiding this comment.
These are just documentation changes and I'm entirely confident in the Kotlin script itself being correct.
Like djc I have to admit my experience here isn't super helpful. This is the only Gradle project I've used and I've written almost zero Kotlin 😆
That said, it seems to match the implementation of the pre-existing Groovy version and since you're confident I think we should merge it without spending any extra time trying to find expert reviews (it is just an example after all).
| @@ -142,7 +142,7 @@ repositories { | |||
| String findRustlsPlatformVerifierProject() { | |||
| def dependencyText = providers.exec { | |||
| it.workingDir = new File("../") | |||
| commandLine("cargo", "metadata", "--format-version", "1", "--manifest-path", "$PATH_TO_DEPENDENT_CRATE/Cargo.toml") | |||
| commandLine("cargo", "metadata", "--format-version", "1", "--filter-platform", "aarch64-linux-android", "--manifest-path", "$PATH_TO_DEPENDENT_CRATE/Cargo.toml") | |||
There was a problem hiding this comment.
Should the text above be updated to mention the --filter-platform? I assume for larger projects it's probably something that can't be fixed to just aarch64-linux-android and needs some special consideration (?)
This PR adds a documented example of how to use the Android component when your Android app uses Kotlin script files instead of Groovy scripts to handle the Gradle build system. We've now had ~2-3 people ask about this, so I think that justifies giving the information a proper spot instead of linking to a issue comment over and over.
The implementation is based primarily off this older example I posted last year, with a few changes adapted from 1P's current production scripts. I opted to keep it in a collapsed section to avoid making the README any longer to scroll through.
Closes #166.