lib: use From trait for KeyUsagePurpose -> u16 #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Aug 26, 2024
| present.then_some(*key_usage) | ||
| }) | ||
| .collect() | ||
| } | ||
| } | ||
|
|
||
| /// Encode a key usage as the value of a BIT STRING as defined by RFC 5280. | ||
| /// [`u16`] is sufficient to encode the largest possible key usage value (two bytes). | ||
| impl From<KeyUsagePurpose> for u16 { |
There was a problem hiding this comment.
I dissuaded the OP from this because I thought we'd prefer to keep this interface private.
There was a problem hiding this comment.
Ah ok! I don't feel strongly in that case. Apologies for the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up from #287 Using a
Fromimpl feels a bit more idiomatic in this case.