Enable botan CI on windows #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some amazing news: randombit/botan-rs#82 (comment) |
This hopefully fixes the windows CI failure
The upstream `botan-rs` crate uses this same action in its Windows based CI, successfully building `botan-sys` on that platform. Without using this action, the build process fails with the error: ``` ERROR: Default compiler is msvc but could not find 'cl'; use --cc to set ``` It's possible that with effort another workaround could be used, but it seems prudent to match what the upstream repository does and its better to have a working setup we can iterate on than one that skips Botan coverage entirely.
|
@est31 I pushed some revisions onto this branch and I think it's ready to go if you want to review.
|
|
@cpu thanks! I think with your changes, we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #118, windows CI was added but the botan specific tests were disabled as the build for rust doesn't work.
I'm opening this PR for future discussion and work on botan support on the windows CI. The goal is to get the CI green, and until then it can't be merged.