Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github-actions ecosystem to dependabot #36

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

cpu
Copy link
Contributor

@cpu cpu commented Apr 10, 2024

👋 It looks like you beat me to this repo for the majority of the CI update tasks. Thanks!

The only omission I noticed that might be worthwhile was configuring dependabot for github actions updates If you wanted to avoid that on purpose for some reason that's OK too, please close as required.

cpu added 2 commits April 9, 2024 20:12
This will let dependabot open PRs for workflow action updates in
addition to cargo dep. updates.
@chifflier
Copy link
Member

Indeed, I tried updating the CI in this crate (if you have feedback on the resulting rust.yml do not hesitate to comment), and it seems to work fine.
I am wondering if I should add feature test matrix for more cases (like clippy), since for example I forgot to add --all-features, and it lead to catching a warning (fixed in 2d84192).

The jobs can be a bit painful though, because it upgrades clippy to nightly, and several warnings were added since stable.
That said, it's a good thing :)

@chifflier chifflier merged commit 26f6751 into rusticata:master Apr 10, 2024
13 checks passed
@chifflier
Copy link
Member

Merged, thanks!

@cpu cpu deleted the cpu-ci-refresh branch April 10, 2024 13:13
@cpu
Copy link
Contributor Author

cpu commented Apr 10, 2024

I am wondering if I should add feature test matrix for more cases (like clippy),

SGTM. I left a comment on the pcap-parser PR suggesting we crib from this repo. If that works for you I'll update the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants