Skip to content

Add --verbose flag to reduce logging to warning+ level, Add spinner #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

x0rw
Copy link
Contributor

@x0rw x0rw commented Apr 30, 2025

now it looks clean but deserted,
So i added a simple spinner (|/-\) during build to give a sense of progress, especially when output is minimal.

There’s definitely room for more improvements in the output, but this is a good start.
Give it a try!
Resolves #66

Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @x0rw! See my comment below.

In addition, one thing that I think would be useful to see fixed as a part of this is to remove this output:

checking consistency... No missing required field
No missing required field
No missing required field
No missing required field
No missing required field
No missing required field
No missing required field
No missing required field

@@ -0,0 +1,35 @@
import sys
Copy link
Collaborator

@PLeVasseur PLeVasseur May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than a spinner, I think it'd be nice to share both:

  • % through processing guidelines
  • x/n through processing guidelines

Where the % and x/n could be derived from the guidelines being rendered. Probably to also highlight where at in the stages of guidelines processing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally i did what you just suggested manually but it builds so fast that using a progress bar gets overriden or broken or actually slowing down the build(threading issues) so i went back to this minimal version.
But i can use this tqdm python library to take care of these issues in the next commit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it. If you can get it working with tqdm that's great. Let's revisit when you've given that a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PLeVasseur -- It works well, i got a hang of it now -- don't mind the repetitive code at the top and the imports i wll clean them up tomorrow, there is a sleep(0.1) after every progress bar for testing, run with ./make.py -c don't run with -v as those verbossy debugging logs break progress bars, i will disable them later,
i will personally perform a sleep(25200) now.

@x0rw x0rw force-pushed the feature-flag/verbose-option branch from 34106f5 to f78999d Compare May 8, 2025 00:50
@x0rw x0rw force-pushed the feature-flag/verbose-option branch from f78999d to a77d593 Compare May 8, 2025 01:02
@x0rw x0rw requested a review from PLeVasseur May 8, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize Verbosity in Sphinx Build Output
2 participants