Skip to content

Windows long is always 4 bytes wide#285

Merged
filmor merged 2 commits intomasterfrom
windows-long-width
Nov 20, 2019
Merged

Windows long is always 4 bytes wide#285
filmor merged 2 commits intomasterfrom
windows-long-width

Conversation

@filmor
Copy link
Copy Markdown
Member

@filmor filmor commented Nov 20, 2019

Fixes #284.

@filmor filmor force-pushed the windows-long-width branch from 15c00b4 to 9b0ea12 Compare November 20, 2019 16:44
@filmor filmor force-pushed the windows-long-width branch from 9b0ea12 to abfe1b8 Compare November 20, 2019 16:45
@filmor filmor requested a review from scrogson November 20, 2019 16:46
Comment thread rustler_sys/build.rs Outdated
Ok(ref val) => panic!("Unsupported target pointer width: {}", val),
Err(err) => panic!(
// get size of C long
let long_width = match (env::var("CARGO_CFG_TARGET_POINTER_WIDTH"), env::var("CARGO_CFG_TARGET_OS")) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pull these into vars above to clean up the formatting?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@filmor filmor merged commit ca2a848 into master Nov 20, 2019
@filmor filmor deleted the windows-long-width branch November 21, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mismatched types - enif_make_long(env, i) ^ expected i32, found i64

2 participants