windows: Allow setting Windows titlebar separately from its resize border #4100
+323
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
reviewed
Jan 30, 2025
kchibisov
requested changes
Jan 30, 2025
eugenesvk
force-pushed
the
fr-win-titlebar
branch
2 times, most recently
from
205f47f to
1a20968
Compare
set WS_CAPTION to allow implementing custom titlebar while maintaining resize borders. Currently MARKER_DECORATIONS internal window flag is used for both WS_CAPTION and WS_BORDER
eugenesvk
force-pushed
the
fr-win-titlebar
branch
from
1a20968 to
1bd54e6
Compare
for windows without title bars to allow implementing custom title bars that would handle their own resizing from the top. via TOP_RESIZE_BORDER flag and the corresponding methods to set it. Requires manuall override of WM_NCCALCSIZE and WM_NCACTIVATE to change the border of the non-client window area to 0 and prevent it from being redrawn on window activation events
eugenesvk
force-pushed
the
fr-win-titlebar
branch
5 times, most recently
from
3c6c592 to
6902428
Compare
A minimal example of a window supporting a custom title bar allowing toggling the default title bar on/off, while maintaining control over the resize borders overall and the top resize border specifically The custom title bar itself is not implemented and left as an exercise for the reader
eugenesvk
force-pushed
the
fr-win-titlebar
branch
from
0c439d9 to
0e51d83
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
WS_CAPTIONseparately to allow implementing custom titlebar while maintaining resize borders.Currently
MARKER_DECORATIONSinternal window flag is used for bothWS_CAPTIONandWS_BORDERAlso add a separate way to set the top resize border for windows without title bars to allow implementing custom title bars that would handle their own resizing from the top and thus avoid the default thick resize border at the top that Windows adds when there is no title bar.
Set via
TOP_RESIZE_BORDERwindow flag and the corresponding methods to (un)set/check it. Requires manuall override ofWM_NCCALCSIZEandWM_NCACTIVATEto change the border of the non-client window area to 0 and prevent it from being redrawn on window activation eventscloses #3730
(for testing also used similar (but slightly different due to moving Win to dyn) changes on top of v0.30.8 in https://github.com/eugenesvk/winit/tree/v30_8)
changelogmodule if knowledge of this change could be valuable to userstopless.rsexample that illustrates and allows live toggling of title bar/resize border/top resize border (for wins without a title bar))