Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is that handle types are now
*mut c_void
instead ofisize
. In particular this means we must wrap theHWND
in theWindow
struct to make itSync
. I've changed the publicwinit::platform::windows::{HWND, HMONITOR, HMENU}
type aliases to match.See rust-windowing/raw-window-handle#171. From my understanding, while handles may technically be integers, everyone in charge of actually defining the API surface really wants them to be pointers and it's best to just go with it.
changelog
module if knowledge of this change could be valuable to users