Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to windows-sys 0.59 #4098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valadaptive
Copy link
Contributor

The biggest change is that handle types are now *mut c_void instead of isize. In particular this means we must wrap the HWND in the Window struct to make it Sync. I've changed the public winit::platform::windows::{HWND, HMONITOR, HMENU} type aliases to match.

See rust-windowing/raw-window-handle#171. From my understanding, while handles may technically be integers, everyone in charge of actually defining the API surface really wants them to be pointers and it's best to just go with it.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • [n/a] Created or updated an example program if it would help users understand this functionality

@valadaptive valadaptive requested a review from notgull as a code owner January 29, 2025 08:09
@madsmtm madsmtm added DS - windows dependencies Pull requests that update a dependency file labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file DS - windows
Development

Successfully merging this pull request may close these issues.

2 participants