Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cargo-apk with the stable toolchain #3098

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

daxpedda
Copy link
Member

I noticed that the cargo-apk installation fails because it's currently broken on nightly, but even if we want to test Android on nightly, we require cargo-apk to be installed with the nightly toolchain.

Also removed caching nightly and stable cargo-apk separately, the output is the same now after all.

@notgull
Copy link
Member

notgull commented Sep 15, 2023

cargo-apk is deprecated, we should be using xbuild instead, see #3086

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xbuild should be handled separately and shouldn't block the CI fix.

Especially given that I'd like to know on xbuild from the android maintainers in the first place.

@kchibisov kchibisov merged commit 9df7fc4 into rust-windowing:master Sep 16, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants