Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
cursor_position
getter API #2648base: master
Are you sure you want to change the base?
Add
cursor_position
getter API #2648Changes from all commits
7f55366
04aec3c
7495b2f
d2bd7af
5b34692
5555119
71985a8
e08d28d
64f7e38
4d6d78d
86506db
a6a7636
f976f2f
5f811f8
e48ec28
37dbcc7
9ee1fd6
261a709
76ba0b6
61db908
1f9a3df
cd6b857
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It confused me that the return type of this is not
PhysicalPosition<i32>
like the return type ofWindow::outer_position
, but I guess it matches theCursorMoved
event - apparently cursors can be positioned on a sub-pixel scale, didn't know that!