Inflight I/O: Fix the memory layout of queue region header #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangjaycee
force-pushed
the
fix_inflight_layout
branch
from
ffb2596
to
e800a14
Compare
As defined in the vhost-user protocol[1], the last field of queue region header should be a zero-sized array. However, current implementation uses u64, which will cause a wrong inflight I/O memfd memory layout. So, let's just remove the desc fileds to fix it. [1] https://qemu-project.gitlab.io/qemu/interop/vhost-user.html Signed-off-by: Jiachen Zhang <[email protected]>
zhangjaycee
force-pushed
the
fix_inflight_layout
branch
from
e800a14
to
c5f62ee
Compare
|
Yep, it seems wrong. Maybe we should use |
|
could you please help to rebase or try FamStruct from vmm_sys_util crate? |
sboeuf
previously approved these changes
Dec 20, 2021
|
@zhangjaycee we would like to fix this problem. Do you have plans to complete this PR? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in the vhost-user protocol[1], the last field of queue region
header should be a zero-sized array. However, current implementation uses
u64, which will cause a wrong inflight I/O memfd memory layout. So, let's
just remove the desc fileds to fix it.
[1]
https://qemu-project.gitlab.io/qemu/interop/vhost-user.html#inflight-i-o-tracking
Signed-off-by: Jiachen Zhang [email protected]