staging: add [workspace.lints] to manifest
#547
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, LGTM, just a couple of questions:
|
We need to update the CI rust to 1.74 first, otherwise the lints won't be picked up from the workspace.
Yeah, there might be a lot of errors. Incrementally sounds good! |
epilys
force-pushed
the
rust-1.74-lints
branch
from
4a119f6
to
399a656
Compare
From Rust 1.74 and onwards, this section enables opt-in lints for crates of this workspace. Read more information at https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html For a crate to opt-in, it needs to set [lints] workspace = true In its Cargo.toml Closes rust-vmm#518 Signed-off-by: Manos Pitsidianakis <[email protected]>
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
epilys
force-pushed
the
rust-1.74-lints
branch
from
399a656
to
9a3157d
Compare
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
No functional changes. Signed-off-by: Manos Pitsidianakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR enables all crates of the staging workspace to share lints. With 1.74 it is now possible to define them in
Cargo.toml.Note: In older versions you'll simply get a "warning: unused manifest key" when using cargo.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.