Sendqueue pkt header size #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rustc-serialize, which has had a history of causing builds to print deprecation warnings.
… pull in rustc-serialize, which has had a history of causing builds to print deprecation warnings." This reverts commit 36138ca.
that want to precalculate required total SendQueue size. This size is available using other types in the crate, but tying the query to the `SendQueue` allows us to avoid a breaking change in case the SendQueue's header ever changes (even though this is highly unlikely to happen).
Wojtek242
requested changes
Dec 19, 2024
There was a problem hiding this comment.
@qrnch-jan the code does not look windows-exclusive. Would you be able to add this function to some reasonable place that is accessible on all platforms and add a small unit test to ensure code coverage?
|
@Wojtek242 It is indeed not strictly Windows-exclusive, but the reason I put it there was to emphasize that it's the size of the packet header used by {win,n}pcap send queues, and it's the size one should use to calculate required sendqueue sizes. I have moved the function, and documented that it's the one that should be used by |
Wojtek242
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a gap for applications that want to precalculate the exact
SendQueuesize required for a batch of packets -- the application doesn't know[*] the exact size of the packet header that is implicitly added with each packet. This PR adds a constant function, tied toSendQueue, that will allow applications to easily get the size without bothering with any other details.[*] Well, this isn't technically true -- it happens to be the same size and layout as packet headers found elsewhere in the crate. However, the benefit of this implementation is that it considers the exact type an implementation detail that the application doesn't need to care about.