-
Notifications
You must be signed in to change notification settings - Fork 3
build(deps): upgrade dependencies #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -28,6 +28,6 @@ zerocopy-derive = { version = "0.8", optional = true } | |||
[features] | |||
alloc = ["dep:allocator-api2"] | |||
mmio = [] | |||
nightly = ["allocator-api2/nightly"] | |||
nightly = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Typically, this is called "unstable" rather than "nightly" I think, but we can keep it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen both, but always thought "nightly" was to be the way to go.
Both seem to be used a lot ("nightly", "unstable").
I think "nightly" was used first, but that does not mean it's necessarily better, of course.
Tokio uses cfg(tokio_unstable)
for signalling that a Tokio API may change without a major version bump (the features do not require a nightly toolchain though).
So it makes sense to me to use "nightly" for signalling that parts of our API are only usable on nightly and may break of course, but that's not because of us but because of the nightly toolchain.
I think I'll keep this as is, but looking into this was interesting! :D
See the projects README for the reasons for removing the nightly feature: https://github.com/zakarumych/allocator-api2/tree/2873b737304003b1cf0c999f4148497293cc9e0f#usage
``` Locking 10 packages to latest compatible versions Updating bitflags v2.6.0 -> v2.9.1 Updating num_enum v0.7.3 -> v0.7.4 Updating num_enum_derive v0.7.3 -> v0.7.4 Updating proc-macro2 v1.0.87 -> v1.0.95 Updating quote v1.0.37 -> v1.0.40 Adding rustversion v1.0.21 Updating syn v2.0.79 -> v2.0.104 Updating unicode-ident v1.0.13 -> v1.0.18 Updating zerocopy v0.8.5 -> v0.8.26 Updating zerocopy-derive v0.8.5 -> v0.8.26 ```
This
Cargo.lock
.