Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wrapper for Highs_setSolution() #14

Closed
wants to merge 1 commit into from
Closed

Conversation

yongqli
Copy link
Contributor

@yongqli yongqli commented Mar 19, 2024

The doc comments could probably be improved, please feel free to edit it.

@mmghannam
Copy link
Contributor

Hi @yongqli, thanks for your contribution! Could you please add tests? For example you can set a solution with value 50 to a model and solving with zero time limit and making sure its primal bound is 50.

@KnorpelSenf
Copy link
Collaborator

Is somebody still working on this?

@lovasoa
Copy link
Contributor

lovasoa commented Jan 8, 2025

I don't think so. If you want to start where @yongqli left off, that would be very welcome !

Comment on lines +479 to +483
/// # Panics
///
/// If the data passed in do not have the correct lengths.
/// `cols` and `col_duals` should have the lengths of `num_cols`.
/// `rows` and `row_duals` should have the lengths of `num_rows`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this returns an error type, wouldn't it be better to return a clean error instead of panicking ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a documentation error, isn't it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hang on, I was looking at the wrong code, nevermind

@KnorpelSenf
Copy link
Collaborator

I don't think so. If you want to start where @yongqli left off, that would be very welcome !

I'll see what I can do :)

@KnorpelSenf
Copy link
Collaborator

@lovasoa I opened #22.

@lovasoa lovasoa closed this in #22 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants