-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wrapper for Highs_setSolution() #14
Conversation
Hi @yongqli, thanks for your contribution! Could you please add tests? For example you can set a solution with value 50 to a model and solving with zero time limit and making sure its primal bound is 50. |
Is somebody still working on this? |
I don't think so. If you want to start where @yongqli left off, that would be very welcome ! |
/// # Panics | ||
/// | ||
/// If the data passed in do not have the correct lengths. | ||
/// `cols` and `col_duals` should have the lengths of `num_cols`. | ||
/// `rows` and `row_duals` should have the lengths of `num_rows`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this returns an error type, wouldn't it be better to return a clean error instead of panicking ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a documentation error, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hang on, I was looking at the wrong code, nevermind
I'll see what I can do :) |
The doc comments could probably be improved, please feel free to edit it.