Std axis #486
Closed
Std axis #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid panicking if length of axis is equal to 1. Added panic if ddof is greater or equal than the length of the variance axis.
…to avoid panicking if length of axis is equal to 1. Added panic if ddof is greater or equal than the length of the variance axis.
jturner314
approved these changes
Sep 18, 2018
src/numeric/impl_numeric.rs
Outdated
| A: Float, | ||
| D: RemoveAxis, | ||
| { | ||
| self.var_axis(axis, ddof).mapv(|x| x.sqrt()) |
There was a problem hiding this comment.
I'd change the .mapv into .mapv_into to avoid the extra allocation.
|
Done @jturner314 |
jturner314
added a commit
to jturner314/ndarray
that referenced
this pull request
Sep 19, 2018
|
I merged this PR. I squashed all the commits and fixed some minor whitespace issues. Unfortunately, GitHub doesn't understand that I merged this PR, so I have to manually close it. Thanks @LukeMathWalker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
std_axismethod to compute the standard deviation along an axis. Following up on rust-ndarray/ndarray-stats#1