Depend on itertools >= 0.10 #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jturner314 Thank you for your work on this useful crate! Could you please give this PR a review when you get a chance? |
bluss
reviewed
Aug 20, 2024
| @@ -21,7 +21,7 @@ noisy_float = "0.2.0" | |||
| num-integer = "0.1" | |||
| num-traits = "0.2" | |||
| rand = "0.8.3" | |||
| itertools = { version = "0.10.0", default-features = false } | |||
| itertools = { version = ">=0.10", default-features = false } | |||
There was a problem hiding this comment.
The right change here is to move it to 1.x 0.13, not have an open ended interval (then users will get broken builds when itertools has breaking changes.)
We'll get to it if we get through with the ndarray 0.16 update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on itertools >= 0.10