Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram error handling #25

Merged
merged 32 commits into from
Apr 2, 2019
Merged

Histogram error handling #25

merged 32 commits into from
Apr 2, 2019

Commits on Jan 29, 2019

  1. Use Option as return type where things might fail

    @LukeMathWalker
    LukeMathWalker committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    bfb0db7 View commit details
    Browse the repository at this point in the history

  2. Test suite aligned with docs

    @LukeMathWalker
    LukeMathWalker committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    4057a72 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Equispaced does not panic anymore

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    fa1eb34 View commit details
    Browse the repository at this point in the history

  2. Fixed some tests

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    669a33f View commit details
    Browse the repository at this point in the history

  3. Fixed FD tests

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    0e5eb6b View commit details
    Browse the repository at this point in the history

  4. Fixed wrong condition in IF

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    04cf0a7 View commit details
    Browse the repository at this point in the history

  5. Fixed wrong test

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    4f429bc View commit details
    Browse the repository at this point in the history

  6. Added new test for EquiSpaced and fixed old one

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    4e74c48 View commit details
    Browse the repository at this point in the history

  7. Fixed doc tests

    LukeMathWalker committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    56b7e45 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. Fix docs.

    @LukeMathWalker
    LukeMathWalker committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    12906fd View commit details
    Browse the repository at this point in the history

  2. Fix docs.

    @LukeMathWalker
    LukeMathWalker committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    9d1862f View commit details
    Browse the repository at this point in the history

  3. Fix docs.

    @LukeMathWalker
    LukeMathWalker committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    64789d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Fmt

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    fe150d1 View commit details
    Browse the repository at this point in the history

  2. Merge master

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    facd4c4 View commit details
    Browse the repository at this point in the history

  3. Create StrategyError

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    b28c35a View commit details
    Browse the repository at this point in the history

  4. Fmt

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    c06f382 View commit details
    Browse the repository at this point in the history

  5. Return Result. Fix Equispaced, Sqrt and Rice

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    4a24f5a View commit details
    Browse the repository at this point in the history

  6. Fix Rice

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f708a17 View commit details
    Browse the repository at this point in the history

  7. Fixed Sturges

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    58788db View commit details
    Browse the repository at this point in the history

  8. Fix strategies

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    3014f77 View commit details
    Browse the repository at this point in the history

  9. Fix match

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    17e5efc View commit details
    Browse the repository at this point in the history

  10. Tests compile

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    63abed5 View commit details
    Browse the repository at this point in the history

  11. Fix assertion

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    4a4b489 View commit details
    Browse the repository at this point in the history

  12. Fmt

    @LukeMathWalker
    LukeMathWalker committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f692887 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Add more error types

    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    a8ad4b1 View commit details
    Browse the repository at this point in the history

  2. Rename StrategyError to BinsBuildError

    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    29f56f3 View commit details
    Browse the repository at this point in the history

  3. Make GridBuilder::from_array return Result 

    This is nice because it doesn't lose information. (Returning an
`Option` combines the two error variants into a single case.)
    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    bca2dc9 View commit details
    Browse the repository at this point in the history

  4. Make BinsBuildError enum non-exhaustive 

    Once the `#[non_exhaustive]` attribute is stable, we should replace
the hidden enum variant with that attribute on the enum.
    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    f41b317 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #4 from jturner314/histogram-error-handling 

    Improve error handling
    @LukeMathWalker
    LukeMathWalker committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    308e0e7 View commit details
    Browse the repository at this point in the history

  6. Use lazy OR operator.

    @LukeMathWalker
    LukeMathWalker committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    c280c6b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/histogram-error-handling' into h… 

    …istogram-error-handling

# Conflicts:
#	src/histogram/strategies.rs
    @LukeMathWalker
    LukeMathWalker committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    6481509 View commit details
    Browse the repository at this point in the history

  8. Use lazy OR operator.

    @LukeMathWalker
    LukeMathWalker committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    701842d View commit details
    Browse the repository at this point in the history