-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Use Option as return type where things might fail * Test suite aligned with docs * Equispaced does not panic anymore * Fixed some tests * Fixed FD tests * Fixed wrong condition in IF * Fixed wrong test * Added new test for EquiSpaced and fixed old one * Fixed doc tests * Fix docs. * Fix docs. * Fix docs. * Fmt * Create StrategyError * Fmt * Return Result. Fix Equispaced, Sqrt and Rice * Fix Rice * Fixed Sturges * Fix strategies * Fix match * Tests compile * Fix assertion * Fmt * Add more error types * Rename StrategyError to BinsBuildError * Make GridBuilder::from_array return Result This is nice because it doesn't lose information. (Returning an `Option` combines the two error variants into a single case.) * Make BinsBuildError enum non-exhaustive Once the `#[non_exhaustive]` attribute is stable, we should replace the hidden enum variant with that attribute on the enum. * Use lazy OR operator. * Use lazy OR operator.
- Loading branch information
1 parent
d838ee7
commit 86e5ca4
Showing
10 changed files
with
423 additions
and
211 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.