Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eigg function which is a wrapper to ggev #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

selvavm
Copy link

@selvavm selvavm commented Apr 18, 2021

This is to resolve #267. It is equivalent of eig(A,B) in Matlab

Added doc comments for eigg function

Added testcase
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a561e5a). Click here to learn what that means.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #280   +/-   ##
=========================================
  Coverage          ?   88.86%           
=========================================
  Files             ?       71           
  Lines             ?     3727           
  Branches          ?        0           
=========================================
  Hits              ?     3312           
  Misses            ?      415           
  Partials          ?        0           
Impacted Files Coverage Δ
lax/src/eig.rs 84.72% <81.66%> (ø)
ndarray-linalg/src/eig.rs 81.81% <100.00%> (ø)
ndarray-linalg/tests/eig.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a561e5a...2d6ab5f. Read the comment docs.

@selvavm
Copy link
Author

selvavm commented Apr 19, 2021

@termoshtt - could you please review this?

@termoshtt termoshtt self-requested a review April 24, 2021 05:57
@selvavm
Copy link
Author

selvavm commented Apr 25, 2021

@termoshtt - I noticed that eigh is using (a,b).eigh() and my implementation is a.eigg(&b). For the former there is no documentation, so it is hard to find.

I can change my implementation to be consistent with it. That is change mine to (a,b).eig(). How do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to do eig(A,B)?
1 participant