Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use workspace dependencies #207

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

SolidTux
Copy link

@SolidTux SolidTux commented Jan 3, 2025

This updates the dependencies. To simplify this and clean up the workspace, I moved the common dependencies to the workspace to avoid version mismatches.

The code adaptations are in separate commits, in case some of them are wrong or not wanted.

Currently missing because I don't know how to adapt to the breaking changes:

  • zip: this removed start_file_aligned and I couldn't find where the functionality is now
  • quick-xml: this broke the serialization of the struct variants in Capabilities

@MarijnS95
Copy link
Member

MarijnS95 commented Jan 3, 2025

Bumping semver compatible versions doesn't serve us anything except annoy anyone who's building with -Zminimal-versions to use newer crates (potentially with higher MSRV). Don't blatantly bump random patch/minor versions without understanding what this means. I'd rather see a patch that lowers versions and installs a cargo +nightly -Zminimal-versions generate-lockfile && cargo check in CI to ensure that our minimum bound is always adequate.

The code adaptations are in separate commits, in case some of them are wrong or not wanted.

It's hard to read because some are separated, but others are bundled in "some dependency updates" commit. I'd rather see separate PRs for individual breaking dependency upgrades that require code changes, commits won't - intentionally - persist after a squash-merge.

@SolidTux
Copy link
Author

SolidTux commented Jan 3, 2025

Ok, will do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants