Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy permission bits when copying files #27

Closed
wants to merge 1 commit into from

Conversation

kuviman
Copy link

@kuviman kuviman commented Jun 12, 2023

I was using NixOS and copying files from nix store resulted in them not having write permissions, so only the first build could succeed, and later ones would fail to overwrite the file. This fix has solved the issue for me.

@MarijnS95
Copy link
Member

A similar albeit different thing is done in #21, can you communicate with @Philipp-M what hacks are needed to support nix?

@kuviman
Copy link
Author

kuviman commented Jun 28, 2023

I guess I failed to find existing PR when creating mine. I think using std::fs::copy is better since it uses some platform apis, and only falls back to io::copy if that's unavailable so I think the other PR is better

@kuviman kuviman closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants