Skip to content

Conversation

@madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Oct 22, 2025

I've been thinking a lot about sandboxing build scripts and proc-macros lately, and it occurred to me that if I were to attack this repo, I'd go the route of adding a ctor to some deeply nested dependency that sends the GITHUB_TOKEN somewhere if it detects it's inside this repo, and then just wait for Dependabot to update the dependency here.

CC @Kobzol, opening this to ensure that this is something you / t-infra is aware of.

@github-actions
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-analyzer/smol_str':
      Permission Changes:
        Removing user 'alexheretic''s write permission 

@jieyouxu jieyouxu added the T-infra Relevant to the infrastructure team. label Oct 22, 2025
@Kobzol
Copy link
Member

Kobzol commented Oct 23, 2025

Good point. We made some mitigations against this, but it's not perfect.

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. T-infra Relevant to the infrastructure team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants