Skip to content

aarch64: use core::intrinsics::simd for integer min/max #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

aarch64: use core::intrinsics::simd for integer min/max #1858

merged 1 commit into from
Jul 11, 2025
+80 −220

Conversation

folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Jul 10, 2025 •
edited
Loading

turns out floats are hard and our current instruction tests don't catch the error if fmin is expected but fminmn is actually used.

@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2025

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@folkertdev folkertdev force-pushed the aarch-comparison-operators branch from 8629f8e to 3bbe1f2 Compare July 10, 2025 13:04
@folkertdev folkertdev changed the title aarch64: use core::intrinsics::simd for min/max aarch64: use core::intrinsics::simd for integer min/max Jul 10, 2025
@sayantn sayantn added this pull request to the merge queue Jul 11, 2025
Merged via the queue into rust-lang:master with commit 017a657 Jul 11, 2025
62 checks passed
@folkertdev folkertdev mentioned this pull request Jul 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sayantn sayantn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folkertdev @rustbot @sayantn