Stabilize keylocker intrinsics and runtime detection #1795

sayantn · 2025-05-07T19:56:47Z

currently draft because this requires the lang and libs-api fcp to complete

rustbot · 2025-05-20T18:51:57Z

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

sayantn · 2025-05-31T06:27:42Z

Libs-api FCP is now complete, so this should be fine to merge now

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc `@rust-lang/lang` cc `@rust-lang/libs-api` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc `@Amanieu.` I will send the reference pr soon.

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ``@rust-lang/lang`` cc ``@rust-lang/libs-api`` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ``@Amanieu.`` I will send the reference pr soon.

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ```@rust-lang/lang``` cc ```@rust-lang/libs-api``` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ```@Amanieu.``` I will send the reference pr soon.

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.

Rollup merge of #140766 - sayantn:stabilize-keylocker, r=traviscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue #134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - #134814 - rust-lang/stdarch#1706 - #136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - #141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.

sayantn mentioned this pull request May 7, 2025

Tracking Issue for keylocker_x86 rust-lang/rust#134813

Open

4 tasks

This was referenced May 15, 2025

Stabilize keylocker rust-lang/rust#140766

Merged

Add doc for keylocker target features rust-lang/reference#1829

Merged

Stabilize keylocker intrinsics and runtime detection

19a7201

sayantn force-pushed the stabilize-keylocker branch from 65ab960 to 19a7201 Compare May 20, 2025 18:48

sayantn marked this pull request as ready for review May 20, 2025 18:51

rustbot assigned Amanieu May 20, 2025

Amanieu added this pull request to the merge queue May 31, 2025

Merged via the queue into rust-lang:master with commit 5672fcd May 31, 2025
62 checks passed

sayantn deleted the stabilize-keylocker branch May 31, 2025 11:18

sayantn mentioned this pull request Jun 3, 2025

Update stdarch submodule rust-lang/rust#141964

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize keylocker intrinsics and runtime detection #1795

Stabilize keylocker intrinsics and runtime detection #1795

Uh oh!

sayantn commented May 7, 2025 •

edited

Loading

Uh oh!

rustbot commented May 20, 2025

Uh oh!

sayantn commented May 31, 2025

Uh oh!

Uh oh!

Uh oh!

Stabilize keylocker intrinsics and runtime detection #1795

Stabilize keylocker intrinsics and runtime detection #1795

Uh oh!

Conversation

sayantn commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 20, 2025

Uh oh!

sayantn commented May 31, 2025

Uh oh!

Uh oh!

Uh oh!

sayantn commented May 7, 2025 •

edited

Loading