chore: grant Jake playground ec2 ssh permissions #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Sep 25, 2024
shepmaster
reviewed
Sep 25, 2024
| "Effect" : "Allow", | ||
| "Action" : "ec2-instance-connect:SendSSHPublicKey", | ||
| "Resource" : [ | ||
| "arn:aws:ec2:us-west-1:890664054962:instance/i-04db6ae41566bd1d9", |
There was a problem hiding this comment.
Would it make sense to do this via "tags" and give playground instances a tag? That way it works for the next playground instances for free.
| ], | ||
| "Condition" : { | ||
| "StringEquals" : { | ||
| "ec2:osuser" : "shepmaster" |
There was a problem hiding this comment.
I'm not sure about this value; the docs suggest it being the user that the AMI creates (e.g. ubuntu for us, I think).
If it is my OS username, that'd be shep.
MarcoIeni
force-pushed
the
chore-grant-jake-playground-ec2-ssh-permissions
branch
from
5e3f61d
to
f373899
Compare
|
applied |
MarcoIeni
deleted the
chore-grant-jake-playground-ec2-ssh-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.